| Code should gracefully handle cases when feature X or plugin Y areĭisabled.
#Typeit4me date math issue manual#
To test for this case weĪdd plenty of unit tests around this logic and document manual testing In logical error, but will degrade performance. | Tasks are idempotent, so executing them multiple times will not result When multiple Kibana nodes are polling for the same tasks. | Multiple nodes-Elasticsearch polling might have race conditions Supported in non-default Kibana Space and when user switches between | Low | High | Integration tests will verify that all features are still | Multiple Spaces-unexpected behavior in non-default Kibana Space. | Risk | Probability | Severity | Mitigation/Notes | When forming the risk matrix, consider some of the following examplesĪnd how they may potentially impact the change: Identify risks that should be tested prior to the change/feature This was checked for [cross-browserĭelete this section if it is not applicable to this PR.īefore closing this PR, invite QA, stakeholders, and other developers to This renders correctly on smaller devices using a responsive If a plugin configuration key changed, check if it needs to beĪllowlisted in the cloud and added to the [docker Any UI touched in this PR does not create any new axe failures Any UI touched in this PR is usable by keyboard only (learn more Were updated or added to match the most common scenarios Was added for features that require explanation or tutorials Know which one do you prefer cc Checklistĭelete any items that are not applicable to this PR. * a more general approach using `constants(value=".")`Ī cloud deployment has been created to test both approaches here. General approach with `constant(.)` removed Would defer this task later in another PR. (between pure vs impure fns) but that took longer than expected, so I I've tried a different organization of the helpers * I had to duplicate a couple of function from the helpers to avoid This is the same behaviour as in TSVB,īut in Lens it can be a problem due to the usage of `calendar_interval`. DST changes, leap years, etc.), rather return the * The `interval()` function does not take into account different bucket * The `interval()` function will report an error if used without a Ok without the `Date Histogram` dimension. a formula with only `interval()` or `now()`). Therefore it is not possible to build a date histogram with a context * context values work like static values, with the same limits, TSVB => Lens with `params._interval` support: * direct exposure of the `time_range()` - as suggested in #117548)Ī visual explanation of what each constant represent: This PR contains constant function features in Lens formula: Should it be possible to define a date-only formula? Right now it's limited to numerical output.Which functions do we need for date math?.Right now there's a workaround for some cases by using runtime fields instead, but this doesn't work for dates originating from different documents. Also, tinymath functions would either need to be extended to handle dates as well or we would have to introduce additional functions for date math specifically, e.g seconds_between(last_value(end_date), last_value(start_date)). We would have to track the data type when traversing the AST - for example it doesn't make sense to subtract a date from a number and vice versa.
This would be a nice addition to todays feature set, but it brings a bunch of technical complexity to formula we could avoid so far. A common use case is to calculate the elapsed time between two dates (like last_value(end_date) - last_value(start_date)). At the moment Lens formula can only deal with numerical values.
0 kommentar(er)
